[webkit-reviews] review denied: [Bug 82612] Web Inspector: [Chromium] Implement Chromium-specific part of the device metrics emulation : [Attachment 134804] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 82612: Web Inspector: [Chromium] Implement Chromium-specific part of the
device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82612

Attachment 134804: Patch
https://bugs.webkit.org/attachment.cgi?id=134804&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134804&action=review


> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:191
> +	       return;

What for were we creating newSize?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:200
> +	   if (!wasEmulated) {

You should instead split init and update methods.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:205
> +

Too much white space

> Source/WebKit/chromium/src/WebViewImpl.cpp:3447
> +    m_layerTreeView.setViewportSize(size());

Why did this change?