[webkit-reviews] review requested: [Bug 81701] [QT][WK2] webview API doc : [Attachment 134815] incorporates review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 30 07:45:36 PDT 2012


Mike Sierra <mike.sierra at nokia.com> has asked  for review:
Bug 81701: [QT][WK2] webview API doc
https://bugs.webkit.org/show_bug.cgi?id=81701

Attachment 134815: incorporates review comments
https://bugs.webkit.org/attachment.cgi?id=134815&action=review

------- Additional Comments from Mike Sierra <mike.sierra at nokia.com>
OK, thanks for all the feedback.  Incorporated all changes.

My slightly longer comment on "schemaRE" suggests it's conceivable (but
unlikely) that you might use a scheme prefix to refer to pages on your own
website.

I changed your "favIcon" to "appIcon" to avoid confusion with the tiny 16x16
favicons that are deployed differently in desktop browsers, and added a note to
clarify that point.

There are several variables to how apple-touch-icons work on various browsers
("size," "precomposed" and whether a fixed filename is placed in the server
root rather than specified in markup) but I didn't think that worth getting
into in this context.

I'll take your word for it on parameter shadowing. ;-)


More information about the webkit-reviews mailing list