[webkit-reviews] review denied: [Bug 82729] [GTK] Disable introspection build in the at-spi2-core module : [Attachment 134801] proposed patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 82729: [GTK] Disable introspection build in the at-spi2-core module
https://bugs.webkit.org/show_bug.cgi?id=82729

Attachment 134801: proposed patch
https://bugs.webkit.org/attachment.cgi?id=134801&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134801&action=review


Looks good indeed but the ChangeLog just needs a little update.

> Tools/ChangeLog:3
> +	   Introspections needs to be disable for "at-spi2-core" module

Can you use the updated bug title please?

> Tools/ChangeLog:9
> +	   Fixes jhbuild issue for gtk.
> +	   Disabling Introspection for at-spi2-core module.

Just mention that this change is a follow-up of bug 82395 which initially
disabled for other modules of the set.