[webkit-reviews] review denied: [Bug 81660] line break inserted into input field : [Attachment 134753] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied jochen at chromium.org's request for
review:
Bug 81660: line break inserted into input field
https://bugs.webkit.org/show_bug.cgi?id=81660

Attachment 134753: Patch
https://bugs.webkit.org/attachment.cgi?id=134753&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134753&action=review


> Source/WebCore/html/TextFieldInputType.cpp:375
> +    // Do not insert single newline characters, as this will result in a
linebreak being inserted.
> +    if (event->text() == "\n") {
> +	 event->setText(String());
> +	 return;
> +    }

Wrong indentation.

Why this change fixes the bug?
We have eventText.replace('\n', ' '); below.

> LayoutTests/ChangeLog:12
> +	   * fast/forms/textfield-no-linebreak.html: Added.
> +	   *
platform/chromium-mac/fast/forms/textfield-no-linebreak-expected.png: Added.
> +	   *
platform/chromium-mac/fast/forms/textfield-no-linebreak-expected.txt: Added.
> +	   * platform/mac/fast/forms/textfield-no-linebreak-expected.png:
Added.
> +	   * platform/mac/fast/forms/textfield-no-linebreak-expected.txt:
Added.

I think this test can be a ref test.