[webkit-reviews] review granted: [Bug 82195] [Qt] Fix includes after QtDeclarative -> QtQML renaming : [Attachment 134593] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 82195: [Qt] Fix includes after QtDeclarative -> QtQML renaming
https://bugs.webkit.org/show_bug.cgi?id=82195

Attachment 134593: proposed patch
https://bugs.webkit.org/attachment.cgi?id=134593&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134593&action=review


r=me. I'll let Ossy set cq+ for a safe landing :)

> Source/WebKit2/UIProcess/API/qt/qwebnavigationhistory_p.h:34
> -#include <qdeclarative.h>
> +#include <QtQml/qqml.h>

This is more of a nitpick, but there is no reason to use #include
<ModuleName/class-or-header.h> in private header files or cpp files. There is a
reason for adding the "redundant" module name in public header files, but for
private header files and cpp files we can rely on the presence of QT +=
module-name in the .pro file and therefore use the shorter #include <ClassName>
include style.