[webkit-reviews] review granted: [Bug 82674] WebKit should throttle memory pressure notifications in proportion to handler time : [Attachment 134696] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 82674: WebKit should throttle memory pressure notifications in proportion
to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674

Attachment 134696: Patch
https://bugs.webkit.org/attachment.cgi?id=134696&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134696&action=review


r=me

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:52
> +// this is 1/s_holdOffMultiplier percent of the time.

Space around the "/", please.

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:55
>  static const time_t s_secondsBetweenMemoryCleanup = 5;

This name isn't accurate anymore. It should be "s_minimumHoldOffTime".

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:124
> +    time(&startTime);

Slightly better to use WTF::currentTime(), since that's the custom in WebKit.