[webkit-reviews] review requested: [Bug 82564] [chromium] Remove SkCanvas::LayerIter use from OpaqueRegionSkia : [Attachment 134712] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 19:25:05 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 82564: [chromium] Remove SkCanvas::LayerIter use from OpaqueRegionSkia
https://bugs.webkit.org/show_bug.cgi?id=82564

Attachment 134712: Patch
https://bugs.webkit.org/attachment.cgi?id=134712&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
While it is not in practice now null, the SkPaint* for saveLayer() could be
null, so fixing this patch to work correctly in the face of that.

FYI I'm working on a followup to use SKDrawLoopers more intelligently instead
of just bailing. I say this cuz it's going to mess up the stack in this patch,
but it's a similar idea so fair to do this first I think.


More information about the webkit-reviews mailing list