[webkit-reviews] review granted: [Bug 82656] DFG should optimize a==b for a being an object and b being either an object or null/undefined, and vice versa : [Attachment 134708] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 18:54:08 PDT 2012


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 82656: DFG should optimize a==b for a being an object and b being either an
object or null/undefined, and vice versa
https://bugs.webkit.org/show_bug.cgi?id=82656

Attachment 134708: the patch
https://bugs.webkit.org/attachment.cgi?id=134708&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
CompareEq should always predict bool shouldn't it?  It would seem easier to
just do a single forNode(nodeIndex).set(PredictBoolean); in the AbstractState
logic for it?

r=me


More information about the webkit-reviews mailing list