[webkit-reviews] review granted: [Bug 82653] Merge FrameLoader::finishedLoading() into DocumentLoader::finishedLoading() : [Attachment 134661] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 14:25:23 PDT 2012


Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 82653: Merge FrameLoader::finishedLoading() into
DocumentLoader::finishedLoading()
https://bugs.webkit.org/show_bug.cgi?id=82653

Attachment 134661: patch
https://bugs.webkit.org/attachment.cgi?id=134661&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134661&action=review


> Source/WebCore/loader/FrameLoader.cpp:-1979
> -    // Retain because the stop may release the last reference to it.
> -    RefPtr<Frame> protect(m_frame);

Do we not need this protect variable?


More information about the webkit-reviews mailing list