[webkit-reviews] review granted: [Bug 80423] New renderer for SVGCircleElement : [Attachment 134633] Update per reviewer comments and update text expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 12:43:55 PDT 2012


Eric Seidel <eric at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 80423: New renderer for SVGCircleElement
https://bugs.webkit.org/show_bug.cgi?id=80423

Attachment 134633: Update per reviewer comments and update text expectations
https://bugs.webkit.org/attachment.cgi?id=134633&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134633&action=review


Excepting the odd test_expectations.txt commenting, this LGTM.

> LayoutTests/platform/chromium/test_expectations.txt:1293
> +// BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask-panning.svg =
IMAGE+TEXT
> +// BUGWK53378 MAC : svg/clip-path/deep-nested-clip-in-mask-panning.svg =
IMAGE
> +// BUGWK53378 WIN : svg/clip-path/deep-nested-clip-in-mask.svg = IMAGE+TEXT
> +// BUGWK53378 MAC : svg/clip-path/deep-nested-clip-in-mask.svg = IMAGE

Why the commented out expectations?  Why not just remove them?


More information about the webkit-reviews mailing list