[webkit-reviews] review granted: [Bug 82625] Web Inspector: improve window selection accuracy in vertical overview of timeline panel : [Attachment 134608] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 11:19:00 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 82625: Web Inspector: improve window selection accuracy in vertical
overview of timeline panel
https://bugs.webkit.org/show_bug.cgi?id=82625

Attachment 134608: Patch
https://bugs.webkit.org/attachment.cgi?id=134608&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134608&action=review


> Source/WebCore/ChangeLog:7
> +

Please add: This fixes a number of small errors when calculating window
boundaries for vertical overview mode.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:992
> +	   this._actualBarWidth = Math.min((this.element.width - 2 *
this._outerPadding) / allBarHeights.length, this._maxInnerBarWidth +
maxPadding);

_actualOuterBarWidth


More information about the webkit-reviews mailing list