[webkit-reviews] review granted: [Bug 82587] [Chromium] Move createURLLoader() into Platform : [Attachment 134532] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 82587: [Chromium] Move createURLLoader() into Platform
https://bugs.webkit.org/show_bug.cgi?id=82587

Attachment 134532: Patch
https://bugs.webkit.org/attachment.cgi?id=134532&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134532&action=review


R=me but one question about headers in the comments.

> Source/WebKit/chromium/public/platform/Platform.h:26
> +#include "../../../../Platform/chromium/public/Platform.h"

do we need this forwarding header? I've been assuming that we only need a
forwarding header in here if we expect users of the client API to need to see
the header and don't want them to have to put both APIs on their include path.
I don't think that's true here, since we don't expect users of the API to be
using Platform.h directly, right?

If we do need this to be exposed for users of the client API then I think it
should live in WebKit/chromium/public/

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:34
> +#include "Platform.h"

could this be #include <public/Platform.h> or
"../../../Platform/chromium/public/Platform.h"	to avoid the forwarding header?