[webkit-reviews] review granted: [Bug 82228] GEOLOCATION should be implemented as Page Supplement : [Attachment 134566] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 29 10:36:26 PDT 2012
Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 82228: GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228
Attachment 134566: Patch
https://bugs.webkit.org/attachment.cgi?id=134566&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134566&action=review
Thanks Mark!
> Source/WebCore/Modules/geolocation/GeolocationController.h:32
> +#include "Page.h"
You don't actually need to include page. It's forward declared below. You can
just include Supplementable.h
More information about the webkit-reviews
mailing list