[webkit-reviews] review granted: [Bug 82586] Add a compile assert for the size of RenderBlock : [Attachment 134531] Initial attempt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 29 09:51:44 PDT 2012
Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 82586: Add a compile assert for the size of RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=82586
Attachment 134531: Initial attempt
https://bugs.webkit.org/attachment.cgi?id=134531&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134531&action=review
> Source/WebCore/ChangeLog:9
> + We can't add asserts for FloatingObject and MarginInfo because
they're private to RenderBlock.
You can put the COMPILE_ASSERT in the constructor. At least, that's what we do
for RenderStyle::(Non)InheritedFlags.
More information about the webkit-reviews
mailing list