[webkit-reviews] review denied: [Bug 80135] [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail : [Attachment 134575] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 80135: [BlackBerry] http authenticate dialog popup only once no matter
authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135

Attachment 134575: Patch
https://bugs.webkit.org/attachment.cgi?id=134575&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134575&action=review


Still some issues :)

> Source/WebCore/ChangeLog:5
> +	   RIM PR: 145660

It is better to put this below the Reviewed By line. In fact cq+ might not work
if it is strict about the format.

> Source/WebCore/ChangeLog:9
> +	   Fixed a regression introduced by last patch to fix this PR
(r111810), we should

Better rephrase:

Fixed a regression introduced by r111810, we should

> Source/WebCore/ChangeLog:13
> +	   No new tests.

Why no new tests?

> Source/WebKit/blackberry/ChangeLog:9
> +	   Fixed a regression introduced by last patch to fix this PR
(r111810), which

Same as above.