[webkit-reviews] review denied: [Bug 82600] [Qt][WK2] contentViewportChanged is triggered twice after gesture end : [Attachment 134555] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 82600: [Qt][WK2] contentViewportChanged is triggered twice after gesture
end
https://bugs.webkit.org/show_bug.cgi?id=82600

Attachment 134555: Patch
https://bugs.webkit.org/attachment.cgi?id=134555&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134555&action=review


> Source/WebKit2/ChangeLog:11
> +	   [Qt][WK2] contentViewportChanged is triggered twice after gesture
end
> +	   https://bugs.webkit.org/show_bug.cgi?id=82600
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Remove explicit call to _q_contentViewportChanged from _q_resume.
> +	   It is called through the ViewportUpdateDeferrer when necessary.
> +
> +	   * UIProcess/API/qt/qquickwebview.cpp:

I am not convinced which is why I havent removed this myself.

In the future we will also call resume when brought back fro the background
(visibility change) so we will need to make sure to call this on resume. it
also seems like the proper place.