[webkit-reviews] review granted: [Bug 82559] Fix a crash and an assertion when recovering from a web process crash : [Attachment 134459] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 18:10:12 PDT 2012


Mark Rowe (bdash) <mrowe at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 82559: Fix a crash and an assertion when recovering from a web process
crash
https://bugs.webkit.org/show_bug.cgi?id=82559

Attachment 134459: Patch
https://bugs.webkit.org/attachment.cgi?id=134459&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134459&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:2932
> +    if (_data->_page->drawingArea())
> +	   _data->_page->drawingArea()->waitForPossibleGeometryUpdate();

Maybe introduce a local to avoid dereferencing / calling
_data->_page->drawingArea() twice in a row?


More information about the webkit-reviews mailing list