[webkit-reviews] review granted: [Bug 82544] Factor out common post-insertion logic in ContainerNode : [Attachment 134431] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 82544: Factor out common post-insertion logic in ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=82544

Attachment 134431: Patch
https://bugs.webkit.org/attachment.cgi?id=134431&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134431&action=review


> Source/WebCore/dom/ContainerNode.cpp:1093
> +    ASSERT(parent->refCount());
> +    ASSERT(child->refCount());

great asserts!

> Source/WebCore/dom/ContainerNode.cpp:1095
> +    // Send notification about the children change.

Nit: I realize some of the old instances of this had this comment, but it's
pretty useless. Delete?

> Source/WebCore/dom/ContainerNode.cpp:1099
> +    // Add child to the rendering tree.

Ditto. Useless comment.

> Source/WebCore/dom/ContainerNode.cpp:1108
> +    // Now that the child is attached to the render tree, dispatch
> +    // the relevant mutation events.

Ditto.