[webkit-reviews] review denied: [Bug 82108] [chromium] Dont discard framebuffer while it may be in use. : [Attachment 134406] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Michal Mocny
<mmocny at chromium.org>'s request for review:
Bug 82108: [chromium] Dont discard framebuffer while it may be in use.
https://bugs.webkit.org/show_bug.cgi?id=82108

Attachment 134406: Patch
https://bugs.webkit.org/attachment.cgi?id=134406&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134406&action=review


I'm also confuzzled. We shouldn't be spreading visible knowledge around to more
classes IMO

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:358
>      if (visible)
> -	   ensureFramebuffer();
> +	   ++m_numberOfFramebufferClients;
> +    else
> +	   --m_numberOfFramebufferClients;

how could this ever be something other than 1 or 0? why is this a counter?