[webkit-reviews] review granted: [Bug 82519] Yarr: if we're not using the output array, don't populate it! : [Attachment 134403] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 82519: Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Attachment 134403: Fix
https://bugs.webkit.org/attachment.cgi?id=134403&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134403&action=review


> Source/JavaScriptCore/runtime/RegExp.cpp:221
>  struct RegExpRepresentation {
> -#if ENABLE(YARR_JIT)
> -    Yarr::YarrCodeBlock m_regExpJITCode;
> -#endif
> -    OwnPtr<Yarr::BytecodePattern> m_regExpBytecode;
>  };

This is now an empty struct.  Is that intentional?