[webkit-reviews] review requested: [Bug 82365] Update shape-inside/shape-outside CSS Exclusion properties : [Attachment 134402] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 14:30:41 PDT 2012


Bear Travis <betravis at adobe.com> has asked  for review:
Bug 82365: Update shape-inside/shape-outside CSS Exclusion properties
https://bugs.webkit.org/show_bug.cgi?id=82365

Attachment 134402: updated patch
https://bugs.webkit.org/attachment.cgi?id=134402&action=review

------- Additional Comments from Bear Travis <betravis at adobe.com>
thanks for the quick feedback.
I have added shape-inside and shape-outside to the list of computed style
properties, and updated the tests that check these properties.
I have also renamed the parsing methods to make them more clear. parseShape >
parseClipShape, and parseWrapShape > parseExclusionShape.


More information about the webkit-reviews mailing list