[webkit-reviews] review denied: [Bug 82390] SL bot is hitting SHOULD NEVER BE REACHED in WebCore::valueForLength() on many tests : [Attachment 134394] ProposedPatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 14:15:34 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 82390: SL bot is hitting SHOULD NEVER BE REACHED in 
WebCore::valueForLength() on many tests
https://bugs.webkit.org/show_bug.cgi?id=82390

Attachment 134394: ProposedPatch
https://bugs.webkit.org/attachment.cgi?id=134394&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134394&action=review


> Source/WebCore/ChangeLog:8
> +	   Passing Length structure as const reference.

This needs to explain why you think this will solve the problem.


More information about the webkit-reviews mailing list