[webkit-reviews] review requested: [Bug 82513] minidom configurations should be based on ToolExecutable.xcconfig : [Attachment 134380] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 28 13:16:51 PDT 2012
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 82513: minidom configurations should be based on ToolExecutable.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=82513
Attachment 134380: Patch
https://bugs.webkit.org/attachment.cgi?id=134380&action=review
------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
* Configurations/ToolExecutable.xcconfig: Extract
JAVASCRIPTCORE_RESOURCES_DIR into its own variable. Define
INSTALL_PATH based on TARGET_NAME.
* JavaScriptCore.xcodeproj/project.pbxproj: Base minidom
configurations on ToolExecutable.xcconfig. Remove redundant
PRODUCT_NAME and SKIP_INSTALL variables.
---
3 files changed, 23 insertions(+), 9 deletions(-)
More information about the webkit-reviews
mailing list