[webkit-reviews] review granted: [Bug 82486] [chromium] Fix tiled layer assert for huge layers : [Attachment 134360] Revert prepainting change
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 28 13:05:11 PDT 2012
James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 82486: [chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486
Attachment 134360: Revert prepainting change
https://bugs.webkit.org/attachment.cgi?id=134360&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134360&action=review
OK
> Source/WebKit/chromium/tests/TilingDataTest.cpp:55
> + ASSERT(numTiles >= 0);
in a unit test we should probably use ASSERT_TRUE() from gtest and not ASSERT()
from wtf/ so it's still compiled in for release builds and produces gtest-style
failures
More information about the webkit-reviews
mailing list