[webkit-reviews] review denied: [Bug 82425] [chromium] Split off tiled layer constructs for unit tests into a common header : [Attachment 134218] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 82425: [chromium] Split off tiled layer constructs for unit tests into a
common header
https://bugs.webkit.org/show_bug.cgi?id=82425

Attachment 134218: Patch
https://bugs.webkit.org/attachment.cgi?id=134218&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134218&action=review


I'll admit that I'm not totally sold on this change since there really aren't
other clients of these classes yet.

If you're going to move these things to the header so that they can be reused,
I think you should push a lot more definitions into the cpp file to make
compilation/linking faster and for style reasons.  In particular, all the
constructors and destructors here should probably not be inlined.

> Source/WebKit/chromium/tests/CCTiledLayerTestCommon.h:45
> +class FakeTextureAllocator : public WebCore::TextureAllocator {
> +public:
> +    virtual unsigned createTexture(const WebCore::IntSize&, GC3Denum) {
return 1; }
> +    virtual void deleteTexture(unsigned, const WebCore::IntSize&, GC3Denum)
{ }
> +};

Looks like TextureManagerTest also does this?