[webkit-reviews] review granted: [Bug 81659] [GTK] crash log reports support : [Attachment 134234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 12:15:53 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 81659: [GTK] crash log reports support
https://bugs.webkit.org/show_bug.cgi?id=81659

Attachment 134234: Patch
https://bugs.webkit.org/attachment.cgi?id=134234&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134234&action=review


> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:173
> +	   stderr_lines = errors + (stderr or '<empty>').decode('utf8',
errors='ignore').splitlines()

errors='ignore', huh? didn't know about that ...


More information about the webkit-reviews mailing list