[webkit-reviews] review granted: [Bug 82481] Web Inspector: refactor UI breakpoint listeners. : [Attachment 134337] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 82481: Web Inspector: refactor UI breakpoint listeners.
https://bugs.webkit.org/show_bug.cgi?id=82481

Attachment 134337: Patch
https://bugs.webkit.org/attachment.cgi?id=134337&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134337&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:257
> +	   this._addBreakpointListeners(uiSourceCode);

This method adds breakpoint listeners twice now, I don't think this is what you
meant to do here.

> Source/WebCore/inspector/front-end/SourceFrame.js:-58
> -    Loaded: "loaded"

Could you please mention removing of this event in the ChangeLog?