[webkit-reviews] review granted: [Bug 82450] [chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler : [Attachment 134272] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 82450: [chromium] MediaStream API (JSEP): Introducing
WebPeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=82450

Attachment 134272: Patch
https://bugs.webkit.org/attachment.cgi?id=134272&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134272&action=review


I'm marking this cq+ to avoid the over night round-trip, but please post a
followup patch that adds the comment below.  Many thanks!

> Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp:60
> +    m_webHandler =
adoptPtr(WebKit::webKitPlatformSupport()->createPeerConnection00Handler(this));


Can this fail?

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:413
>      virtual WebPeerConnectionHandler*
createPeerConnectionHandler(WebPeerConnectionHandlerClient*) { return 0; }
> +    virtual WebPeerConnection00Handler*
createPeerConnection00Handler(WebPeerConnection00HandlerClient*) { return 0; }

Can you add a comment explaining the difference between these two?  This
probably looks confusing for folks who haven't been following this discussion
in detail.