[webkit-reviews] review granted: [Bug 82466] Use xcrun to find nm and ranlib on OS X builds : [Attachment 134292] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted David Kilzer (:ddkilzer) <ddkilzer at webkit.org>'s
request for review:
Bug 82466: Use xcrun to find nm and ranlib on OS X builds
https://bugs.webkit.org/show_bug.cgi?id=82466

Attachment 134292: Patch
https://bugs.webkit.org/attachment.cgi?id=134292&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=134292&action=review


> Tools/Scripts/webkitperl/features.pm:57
> +sub nmPath()
> +{
> +    if (isAppleMacWebKit()) {
> +	   my $nm = `xcrun -find nm`;
> +	   chomp $nm;
> +	   return $nm if $nm;
> +    }
> +    return "nm";
> +}

Should this function cache the result? Probably doesn’t matter if we run nm
only on libraries, but could matter if we run it on every new .o file.