[webkit-reviews] review granted: [Bug 82150] Simplify volume slider rendering : [Attachment 134315] Removed pixel test and added text test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 28 10:09:26 PDT 2012
Eric Carlson <eric.carlson at apple.com> has granted Victor Carbune
<vcarbune at adobe.com>'s request for review:
Bug 82150: Simplify volume slider rendering
https://bugs.webkit.org/show_bug.cgi?id=82150
Attachment 134315: Removed pixel test and added text test
https://bugs.webkit.org/attachment.cgi?id=134315&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134315&action=review
> Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp:130
> +
> +
Nit: you have an extra blank line here.
> LayoutTests/media/video-controls-rendering-toggle-display-none.html:22
> + /*
> + if (window.layoutTestController)
> + layoutTestController.waitUntilDone();
> + */
Did you forgot to uncomment this, or is it unnecessary?
More information about the webkit-reviews
mailing list