[webkit-reviews] review granted: [Bug 82369] setNeedsLayout(true, false) is super confusing to read and should use an enum instead : [Attachment 134133] Updated naming

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 82369: setNeedsLayout(true, false) is super confusing to read and should
use an enum instead
https://bugs.webkit.org/show_bug.cgi?id=82369

Attachment 134133: Updated naming
https://bugs.webkit.org/attachment.cgi?id=134133&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134133&action=review


There seem to be a consensus this is a good change so r+'ing. If someone has
some better naming suggestions, that would be the moment.

> Source/WebCore/ChangeLog:12
> +	   I'm not sure the naming is perfect (as it's not clear to me if
markParents is
> +	   used to mean the same thing in these 3 functions), but hopefully
this code is more
> +	   clear.  I welcome further suggested adjustment from layout experts.

I think this can be removed now as you got some suggestions.

> Source/WebCore/rendering/RenderObject.h:100
> +enum MarkingBehavior {

I don't feel strongly about this name (a bit too generic). If you prefer
Simon's naming, you can rename it.