[webkit-reviews] review granted: [Bug 82448] [GTK] generate-gtk-doc doesn't cope with custom build directory : [Attachment 134299] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 82448: [GTK] generate-gtk-doc doesn't cope with custom build directory
https://bugs.webkit.org/show_bug.cgi?id=82448

Attachment 134299: Patch
https://bugs.webkit.org/attachment.cgi?id=134299&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134299&action=review


>> Tools/gtk/common.py:-40
>> -	    return build_dir
> 
> Why do you no longer cache the build directory here?

I cannot see a reason why it isn't. The patch looks great, but I think caching
the build directory was a nice feature in that it avoided touching the file
system every time you needed the build directory. Perhaps you could restore
that before landing?