[webkit-reviews] review requested: [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread : [Attachment 134303] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 08:42:53 PDT 2012


Sami Kyostila <skyostil at google.com> has asked  for review:
Bug 73350: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Attachment 134303: Patch
https://bugs.webkit.org/attachment.cgi?id=134303&action=review

------- Additional Comments from Sami Kyostila <skyostil at google.com>
- Removed page scaling hacks from this patch; let's normalize the coordinates
further upstream instead.
- Avoid recalculating layer transforms on scrollBegin().
- Removed some assumptions about scroll layer hierarchy.
- Avoid traversing tree twice when calculating scroll deltas.
- Removed ScrollableArea bits.
- Added several tests.


More information about the webkit-reviews mailing list