[webkit-reviews] review denied: [Bug 82336] Make it possible to use accelerated compositing for page overlay fading : [Attachment 134297] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Lars Knudsen
<lars.knudsen at nokia.com>'s request for review:
Bug 82336: Make it possible to use accelerated compositing for page overlay
fading
https://bugs.webkit.org/show_bug.cgi?id=82336

Attachment 134297: Patch
https://bugs.webkit.org/attachment.cgi?id=134297&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134297&action=review


> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:91
> +    if (m_webPage &&
!m_webPage->drawingArea()->setPageOverlayOpacity(m_fractionFadedIn))

This test should happen in PageOverlay::fadeAnimationTimerFired, not in
setNeedsDisplay. Would make the whole code a lot more readable.
That way, if set...Opacity returns true, we don't even have to change
fractionFadedIn at all.

> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:107
> +	   if (m_webPage->drawingArea()->layerTreeHost())

This is wrong.