[webkit-reviews] review granted: [Bug 82463] Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode. : [Attachment 134284] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 82463: Web Inspector: dispatch console-message-added and
console-messages-cleared events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82463

Attachment 134284: Patch
https://bugs.webkit.org/attachment.cgi?id=134284&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134284&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:280
> +	      
uiLocation.uiSourceCode.consoleMessageAdded(presentationMessage);

I know this is not related to this patch, but switching to pretty-print mode
and back adds more and more messages to uiSourceCode because they are never
removed from it (unless console is cleared / navigation happens).