[webkit-reviews] review denied: [Bug 82336] Make it possible to use accelerated compositing for page overlay fading : [Attachment 134244] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Lars Knudsen
<lars.knudsen at nokia.com>'s request for review:
Bug 82336: Make it possible to use accelerated compositing for page overlay
fading
https://bugs.webkit.org/show_bug.cgi?id=82336

Attachment 134244: Patch
https://bugs.webkit.org/attachment.cgi?id=134244&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134244&action=review


This would still affect implementations that use LayerTreeHost and
DrawingAreaImpl.
LayerTreeHost::setPageOverlayOpacity is where the difference should occur.

> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:78
> +    virtual void setPageOverlayOpacity(float) = 0;

This function should return bool, and return false by default.