[webkit-reviews] review granted: [Bug 82059] Incorrect foreignObject hit test results when overlapping other SVG elements : [Attachment 134135] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Florin Malita
<fmalita at google.com>'s request for review:
Bug 82059: Incorrect foreignObject hit test results when overlapping other SVG
elements
https://bugs.webkit.org/show_bug.cgi?id=82059

Attachment 134135: Patch
https://bugs.webkit.org/attachment.cgi?id=134135&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r=me. You're doing all of this from the Foreground phase, due the FOs stacking
context. The only renderer that used to care about phases like HitTestFloat or
HotTestChildBlockBackgrounds is RenderSVGFo. Now that this dependency is gone,
we can completely avoid painting() the whole SVG subtree in non-foreground
phases (still exceptions are needed for PaintPhaseSelection I think) - that
would save a lot of time! Can you look into this? (Easy approach, early return
in RenderSVGRoot::paint if phase is not foreground, then see what tests breaks
:-)