[webkit-reviews] review granted: [Bug 76905] [Qt] run-qtwebkit-tests should report crashes : [Attachment 129228] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Ádám Kallai
<kadam at inf.u-szeged.hu>'s request for review:
Bug 76905: [Qt] run-qtwebkit-tests should report crashes
https://bugs.webkit.org/show_bug.cgi?id=76905

Attachment 129228: proposed patch
https://bugs.webkit.org/attachment.cgi?id=129228&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129228&action=review


r=me with removing accidentally uploaded code.

> Tools/ChangeLog:16
> +	   (RunQtAPITestsTest.assertSummary):

Remove it too.

> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:87
> +
> +    def assertSummary(self, expected_text, stdio):
> +	   rc = 0
> +	   cmd = StubRemoteCommand(rc, stdio)
> +	   #step = RunQtWebKitTests()
> +

We still don't need this code. :)