[webkit-reviews] review granted: [Bug 81077] Add support for Intel compiler on Linux QT port. : [Attachment 132758] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted  review:
Bug 81077: Add support for Intel compiler on Linux QT port.
https://bugs.webkit.org/show_bug.cgi?id=81077

Attachment 132758: Patch
https://bugs.webkit.org/attachment.cgi?id=132758&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132758&action=review


>> Tools/qmake/mkspecs/features/default_post.prf:138
>> +	    !linux-g++*:!linux-icc*:contains(QT_CONFIG, reduce_exports):CONFIG
+= hide_symbols
> 
> Please put this one in the icc.prf file as well:
> 
> contains(TEMPLATE, lib):!plugin:contains(QT_CONFIG, reduce_exports):CONFIG +=
hide_symbols

Sorry, my bad, didn't see the ! Keep it like this, but I suspect there's a
better way to write this down the road.