[webkit-reviews] review denied: [Bug 82319] Remove custom bindings form Internals.idl of attribute type Array. : [Attachment 134241] Updated Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 82319: Remove custom bindings form Internals.idl of attribute type Array.
https://bugs.webkit.org/show_bug.cgi?id=82319

Attachment 134241: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=134241&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
The change looks OK to me, but this patch changes the existing behavior of
Internals. First, we need to reach consensus on removing jsNull()/v8::Null()
with Internals folks.

Option1: We can ask it in this bug.
Option2: You can make a patch that simply removes jsNull()/v8::Null() from
JSInternalsCustom.cpp/V8InternalsCustom.cpp as another bug. It will update some
layout tests, because it changes the existing behavior. After the patch is
landed, you can commit this patch.

Both options are fine (but I would prefer Option2.)