[webkit-reviews] review denied: [Bug 58837] Fieldset disabled attribute does not work : [Attachment 134139] patch for review. - fixed issues as commented before.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Zeno Albisser <zeno at webkit.org>'s
request for review:
Bug 58837: Fieldset disabled attribute does not work
https://bugs.webkit.org/show_bug.cgi?id=58837

Attachment 134139: patch for review. - fixed issues as commented before.
https://bugs.webkit.org/attachment.cgi?id=134139&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134139&action=review


> Source/WebCore/html/HTMLFieldSetElement.cpp:80
> +HTMLLegendElement* HTMLFieldSetElement::legend() const
> +{
> +    return m_legend;
> +}

This is called only if a form control is put in a <legend>.  It should be very
rare case, and it should be acceptable to find the <legend> on demand.

So, I propose
 - Remove HTMLFieldSetElement::m_legend
 - HTMLFieldSetElement::legend() finds the first-child <legend> on demand.
 - Revert every changes of HTMLLegendElement.{cpp,h}

> Source/WebCore/html/HTMLFieldSetElement.cpp:95
> +    while ((node = node->traverseNextNode(this))) {

This is wrong.	We should search only direct child nodes for <legend> according
to the specification.
   for (Element* node = firstEleemntChild(); node; node =
node->nextElementSibling()) { ...