[webkit-reviews] review denied: [Bug 79354] [EFL] Add dummy GeolocationClientEfl.cpp | h : [Attachment 134188] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 00:45:23 PDT 2012


Ryuan Choi <ryuan.choi at samsung.com> has denied Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 79354: [EFL] Add dummy GeolocationClientEfl.cpp | h
https://bugs.webkit.org/show_bug.cgi?id=79354

Attachment 134188: Patch
https://bugs.webkit.org/attachment.cgi?id=134188&action=review

------- Additional Comments from Ryuan Choi <ryuan.choi at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134188&action=review


> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.h:50
> +private:
> +    RefPtr<Evas_Object> m_view;
> +};

As discussed in private channel, m_view will be deleted when
GelocationClientEfl is terminated.

So, I preferred this as raw pointer like other *ClientEfl.
Or, you need to refactor ewk_view to control reference count well.


More information about the webkit-reviews mailing list