[webkit-reviews] review granted: [Bug 45228] window.scrollBy() scrolls incorrectly when zoomed in/out : [Attachment 133930] Patch (Revised based on smfr's review. Fixed borken logic. Updated test logic to catch the underlying error as well.)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eugene Girard
<girard at chromium.org>'s request for review:
Bug 45228: window.scrollBy() scrolls incorrectly when zoomed in/out
https://bugs.webkit.org/show_bug.cgi?id=45228

Attachment 133930: Patch (Revised based on smfr's review.  Fixed borken logic. 
Updated test logic to catch the underlying error as well.)
https://bugs.webkit.org/attachment.cgi?id=133930&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=133930&action=review


> Source/WebCore/ChangeLog:8
> +	   window.scrollBy() scrolls incorrectly when zoomed in/out
> +	   https://bugs.webkit.org/show_bug.cgi?id=45228
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: fast/dom/zoom-scroll-page-test.html

This needs some text to say what you did to fix the bug.