[webkit-reviews] review granted: [Bug 82411] [Chromium] Uninitialized access in SimpleFontDataSkia::platformInit() : [Attachment 134194] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 82411: [Chromium] Uninitialized access in
SimpleFontDataSkia::platformInit()
https://bugs.webkit.org/show_bug.cgi?id=82411

Attachment 134194: Patch
https://bugs.webkit.org/attachment.cgi?id=134194&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134194&action=review


> Source/WebCore/ChangeLog:12
> +	   [Chromium] Uninitialized access in SimpleFontDataSkia::platformInit
> +	   https://bugs.webkit.org/show_bug.cgi?id=82411
> +
> +	   SimpleFontDataSkia::platformInit() could call widthForGlyph(), which

> +	   accesses m_zeroWidthSpaceGlyph. This causes a valgrind memcheck
error
> +	   because m_zeroWidthSpaceGlyph isn't initialized at this point.
> +	   Initialize m_zeroWidthSpaceGlyph with zero so that widthForGlyph()
can
> +	   return appropriate value(The value zero here means "unknown glyph").

> +
> +	   Reviewed by NOBODY (OOPS!).

Usual order is:

  <summary>
  <bug URL>

  Reviewd by ...

  <Detail>