[webkit-reviews] review granted: [Bug 82154] [chromium] Route monotonic clock up from compositor : [Attachment 134178] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 82154: [chromium] Route monotonic clock up from compositor
https://bugs.webkit.org/show_bug.cgi?id=82154

Attachment 134178: Patch
https://bugs.webkit.org/attachment.cgi?id=134178&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134178&action=review


Me likey

> Source/WebKit/chromium/src/WebViewImpl.cpp:1338
> +    dobule monotonicFrameBeginTime;

nit: can you initialize this explicitly to make the behavior more predictable
if someone accidentally refactors the code below to no longer set the value?
local variables of primitive types have bitten us a few times before

> Source/WebKit/chromium/src/WebViewImpl.cpp:1341
> +    else {

pretty sure there are no callers to this function with a non-zero value, so
this is a bit theoretical. rather than shifting might be simpler to just grab
monotonicallyIncreasingTime() here no matter what