[webkit-reviews] review granted: [Bug 82396] Reinforce Geolocation to prevent accidental leak of the user position : [Attachment 134171] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 82396: Reinforce Geolocation to prevent accidental leak of the user
position
https://bugs.webkit.org/show_bug.cgi?id=82396

Attachment 134171: Patch
https://bugs.webkit.org/attachment.cgi?id=134171&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134171&action=review


> Source/WebCore/Modules/geolocation/Geolocation.cpp:128
> +    // If we are here and the Geolocation permission is not approved,
something has
> +    // gone horribly wrong.
> +    // We bail out to avoid any privacy issue.
> +    ASSERT(m_geolocation->isAllowed());
> +    if (!m_geolocation->isAllowed())
> +	   return;

Should we CRASH() rather than return here?