[webkit-reviews] review canceled: [Bug 82275] WebGL content swapped at wrong time in threaded compositing mode : [Attachment 133959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 16:58:11 PDT 2012


James Robinson <jamesr at chromium.org> has canceled  review:
Bug 82275: WebGL content swapped at wrong time in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82275

Attachment 133959: Patch
https://bugs.webkit.org/attachment.cgi?id=133959&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Clearing flags - this breaks the multisampled path on Chromium because FBOs
aren't shared between contexts so we can't bind + blit from context other than
the WebGL context.  I'll leave the resolve in paint..() and make sure that we
always double buffer the color attachment and do either a swap or a copy in
updateCompositorResources().  I'll also file a bug about why this isn't caught
by running layout tests, since the multisampled output path is the default.


More information about the webkit-reviews mailing list