[webkit-reviews] review denied: [Bug 82298] WebCore should have centralized interface for adding instrumentations. : [Attachment 134034] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 82298: WebCore should have centralized interface for adding
instrumentations.
https://bugs.webkit.org/show_bug.cgi?id=82298

Attachment 134034: Patch
https://bugs.webkit.org/attachment.cgi?id=134034&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I don't like (or don't understand) the way you are changing things. I'd like to
avoid wrapping inspector instrumentation, I don't see why document
instrumentation and LayoutSchedulingInstrumentation are extracted. I also think
that hiding Chromium-specific TraceEvents behind the WebCore's instrumentation
is a wrong approach. Could you please explain your intent upfront in the bug
and wait for the feedback from the inspector team prior to suggesting patches
for review?