[webkit-reviews] review denied: [Bug 82376] [Coverity] Address uninit constructor issues : [Attachment 134130] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied kmadhusu
<kmadhusu at chromium.org>'s request for review:
Bug 82376: [Coverity] Address uninit constructor issues
https://bugs.webkit.org/show_bug.cgi?id=82376

Attachment 134130: Patch
https://bugs.webkit.org/attachment.cgi?id=134130&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134130&action=review


Most of these changes seem fine, but some do not (see inline comments). Also
please fix the tab characters.

> Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp:62
>  #endif
> +    , m_textTrackDisplay(0)

this should be inside the #if ENABLE() guard, not outside of it

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:569
> +    , m_enabled(false)

I'm not sure this is correct - this bool doesn't seem to actually be used.
maybe it should be deleted instead?

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:130
> +    , m_resolutionScale(0)

i think 1 is a better value to initialize to