[webkit-reviews] review granted: [Bug 41630] [Soup] DNS prefetching spams resolver, shoots self in the foot : [Attachment 133450] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 41630: [Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Attachment 133450: Patch
https://bugs.webkit.org/attachment.cgi?id=133450&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133450&action=review


Looks okay, but before landing:

1. Figure out how to not break EFL. :)
2. Take a look at the line below:

> Source/WebCore/platform/network/cf/DNSCFNet.cpp:95
> -	   atomicDecrement(&m_requestsInFlight);
> +	   DNSResolveQueue::shared().decrementRequestCount();

Can't you just do:

decrementRequestCount();

here. Isn't 'this' already 'DNSResolveQueue::shared()' ?